Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-1486

Perf plugin (perf.js) should not try to draw max and min lines if there are only one result in the list

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v2017.02.01
    • Component/s: perf-tools
    • Labels:
      None

      Description

      The perf plugin has the ability to draw trend graphs with max and min values. That has broken recently for unknown reasons. It's failing trying to draw the max and min on an array of length 1. It seems reasonable to detect and avoid the situation.

      Perf.js checks if max and min should be drawn in this line. It is then used here

      I suggest we change the check on line 610 to also check that the length of the array is greater than 1. That should avoid the problem we are seeing in PERF-836.

        Attachments

          Activity

            People

            Assignee:
            shraya.ramani Shraya Ramani
            Reporter:
            david.daly David Daly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: