Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-14986

Bugsnag should not error when tasklogs are not returned

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor - P4
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: next_quarter
    • Component/s: ui
    • Labels:

      Description

      We currently have bugsnag report an error when ever there is an error returned from a gql query. This results in an error being reported when a task has no logs because the `taskLogs` query returns an error status (404) . We shouldn't throw an error then since that is a valid scenario.

      [https://app.bugsnag.com/mongodb/evergreen/errors/60d34bd2c166250007320de6?filters[event.since][0]=30d&filters[error.status][0]=open]

       

      I can think of 2 possible solutions

      1) Add some filtering logic that allows us to blocklist certain queries from being reported to bugsnag. (Tricky because we might end up underreporting errors and not being able to catch them if there is a genuine error)

      2) Don't return an error when there are no Task Logs, since technically this is the correct response. The query should return an OK status. (This might get tricky because we might need to differentiate between there actually being no logs or there being  something wrong with the logging service) (I prefer this approach)

       

      1) We should check the status of a task and use that to determine if logs should exist for a task or not.  

        Attachments

          Activity

            People

            Assignee:
            backlog-server-evg Backlog - Evergreen Team
            Reporter:
            mohamed.khelif Mohamed Khelif
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: