Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-15919

SaveProjectSettingsForSection resolver: admins are pushed to DB on error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: current_quarter
    • Component/s: app
    • Labels:
      None

      Description

      The SaveProjectSettingsForSection and SaveRepoSettingsForSection resolvers push admin updates to the database even when the call to UpdateAdminRoles returns an error.

      Example: the evergreen project in the local db does not have a project_settings permission defined in the roles collection. As such, any attempt to set an admin should fail. The resolver does correctly return an error, but the changes made to the "admins" array are still pushed to the evergreen document in the project_ref collection.

        Attachments

          Activity

            People

            Assignee:
            annie.black Annie Black
            Reporter:
            sophie.stadler Sophie Stadler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: