Uploaded image for project: 'Evergreen'
  1. Evergreen
  2. EVG-7261

Empty diff in commit-queue

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed
    • Major - P3
    • Resolution: Won't Fix
    • None
    • next_quarter
    • app

    Description

      I use patch_uncommitted_changes: true in my ~/.evergreen.yml file and therefore was able to patch test and code review without committing anything.

      I then did evergreen commit-queue merge -p mongodb-mongo-v3.6 -d "SERVER-xxxx ...". The command succeeds, and I get emails for the merge starting and succeeding. But the diff in the merge is empty and the commit doesn't actually show up in the v3.6 branch in the end. (...which is a good thing).

      This is the commit-queue merge: https://evergreen.mongodb.com/version/5e283a06e3c33179485c92d1

      We were discussing that maybe something here is a bug:

      • Should evergreen have picked up my uncommitted changes, given the configuration in evergreen.yml?
      • Either way, should it reject empty commits? (It doesn't seem to warn about it either.)

      Mostly wanted to share, don't have a strong opinion on what should happen.

      Attachments

        Issue Links

          Activity

            People

              backlog-server-evg Backlog - Evergreen Team
              henrik.ingo@mongodb.com Henrik Ingo (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: