-
Type:
Task
-
Resolution: Fixed
-
Priority:
Minor - P4
-
Affects Version/s: None
-
Component/s: None
-
None
-
Storage Execution
-
Fully Compatible
-
Execution Team 2024-03-18
-
None
-
0
-
None
-
None
-
None
-
None
-
None
-
None
The functions in this file are very hard to follow (aside from being undocumented) often because the one input parameter `request` is last, not first! In many cases there are several input parameters and they all appear before the sole input parameter.
According to the Google Style Guide, input-only parameters should be ordered first, before in/out or output parameters.
Functions (~15, incorrectly ordered params in parentheses):
- insertBatchAndHandleErrors (OperationSource)
- performUpdate(curOp, updateRequest)
- performSingleUpdateOp(containsDotsAndDollarsField)
- performTimeseriesInsert(batch)
- performTimeseriesUpdate(batch)
- tryPerformTimeseriesBucketCompression(request)
- commitTimeseriesBucketsAtomically(request)
- rebuildOptionsWithGranularityFromConfigServer(timeseriesOptions)
- insertIntoBucketCatalog(request)
- performOrderedTimeseriesWritesAtomically(request)
- performUnorderedTimeseriesWrites(request)
- performUnorderedTimeseriesWritesWithRetries(request)
- performOrderedTimeseriesWrites (request)
- explainUpdate(updateRequest)
- explainDelete(deleteRequest)