Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-85274

write_ops_exec.cpp violates style guide on parameter ordering

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 8.0.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Storage Execution
    • Fully Compatible
    • Execution Team 2024-03-18
    • None
    • 0
    • None
    • None
    • None
    • None
    • None
    • None

      The functions in this file are very hard to follow (aside from being undocumented) often because the one input parameter `request` is last, not first! In many cases there are several input parameters and they all appear before the sole input parameter.

      According to the Google Style Guide, input-only parameters should be ordered first, before in/out or output parameters.

      Functions (~15, incorrectly ordered params in parentheses):

      • insertBatchAndHandleErrors (OperationSource)
      • performUpdate(curOp, updateRequest)
      • performSingleUpdateOp(containsDotsAndDollarsField)
      • performTimeseriesInsert(batch)
      • performTimeseriesUpdate(batch)
      • tryPerformTimeseriesBucketCompression(request)
      • commitTimeseriesBucketsAtomically(request)
      • rebuildOptionsWithGranularityFromConfigServer(timeseriesOptions)
      • insertIntoBucketCatalog(request)
      • performOrderedTimeseriesWritesAtomically(request)
      • performUnorderedTimeseriesWrites(request)
      • performUnorderedTimeseriesWritesWithRetries(request)
      • performOrderedTimeseriesWrites (request)
      • explainUpdate(updateRequest)
      • explainDelete(deleteRequest)

            Assignee:
            gregory.wlodarek@mongodb.com Gregory Wlodarek
            Reporter:
            matt.kneiser@mongodb.com Matt Kneiser
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: