-
Type:
Improvement
-
Resolution: Won't Do
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
Labels:
-
3
-
StorEng - Defined Pipeline
WiredTiger statistic files are currently of the format: WiredTigerStat.Day.Hour this means if you run a test N times within the same hour of the same day there is no way to differentiate between the filenames and they may in fact overwrite one another.
I suggest we add a minute specifier to the WiredTigerStat name to make them more differentiable. This is an easy one line change in connection.h.
diff --git a/src/include/connection.h b/src/include/connection.h
index a348415b1..27798d039 100644
--- a/src/include/connection.h
+++ b/src/include/connection.h
@@ -431,7 +431,7 @@ struct __wt_connection_impl {
uint32_t evict_threads_max; /* Max eviction threads */
uint32_t evict_threads_min; /* Min eviction threads */
-#define WT_STATLOG_FILENAME "WiredTigerStat.%d.%H"
+#define WT_STATLOG_FILENAME "WiredTigerStat.%d.%H.%M"
WT_SESSION_IMPL *stat_session; /* Statistics log session */
wt_thread_t stat_tid; /* Statistics log thread */
bool stat_tid_set; /* Statistics log thread set */'
However it may have implication in testing if anything expects the format to be %d.%H.
Scope:
- Update the WT_STATLOG_FILENAME to include minutes.
- Fix any tests that depend on it.