Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2216

simplify row-store search loop slightly

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • WT2.8.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      There's a test for internal pages with a single child in the row-store search function:

      /*
       * Fast-path internal pages with one child, a common case for
       * the root page in new trees.
       */
      if (pindex->entries == 1) {
              descent = pindex->index[0];
              goto descend;
      }
      

      michael.cahill, you put this code in https://github.com/wiredtiger/wiredtiger/commit/875c10c72b6f5bdb53a8e14fc7e15f7491d6b412, do you remember where this made a difference?

      It seems to me it's only useful until we split the root, and then it's wasted from that point on, was there a benchmark that triggered this?

        1. aws.clang36
          9 kB
        2. aws.gcc48
          9 kB
        3. pixie.clang33
          9 kB
        4. rr
          1 kB

            Assignee:
            keith.bostic@mongodb.com Keith Bostic (Inactive)
            Reporter:
            keith.bostic@mongodb.com Keith Bostic (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: