Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2707

dist/s_label enhancements, and error jump cleanups

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • WT2.9.0, 3.3.9
    • Affects Version/s: WT2.8.0
    • Component/s: None
    • Labels:
      None

      When s_label determine if a jump to the error label (e.g. WT_ERR) occurs before a regular return (e.g. WT_RET), it should match other macros, like WT_RET_ERROR_OK().

      Also, within a loop, any mixing of WT_RET (and friends) and WT_ERR (and friends) is incorrect:

          WT_RET(f());
          while (cond) {
             WT_RET(g());
             WT_ERR(h());
          }
      

      This example is currently allowed, but can be detected.

      I've marked this as a bug as it will require some code fixes.

            Assignee:
            donald.anderson@mongodb.com Donald Anderson
            Reporter:
            donald.anderson@mongodb.com Donald Anderson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: