[CDRIVER-1019] In mongoc-read-concern-private.h, mongoc-read-concern.h is included "wrongly" Created: 20/Nov/15  Updated: 08/Dec/15  Resolved: 20/Nov/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: 1.3.0-beta0
Fix Version/s: 1.3.0-rc0

Type: Bug Priority: Major - P3
Reporter: Derick Rethans Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends

 Description   

When compiling the HHVM driver against libmongoc, I am now getting the following error:

```
[ 2%] Building C object CMakeFiles/mongodb.dir/libmongoc/src/mongoc/mongoc-collection.c.o
In file included from /home/derick/dev/php/mongodb-mongo-hhvm-driver/libmongoc/src/mongoc/mongoc-collection.c:35:0:
/home/derick/dev/php/mongodb-mongo-hhvm-driver/libmongoc/src/mongoc/mongoc-read-concern-private.h:25:33: fatal error: mongoc-read-concern.h: No such file or directory
compilation terminated.
CMakeFiles/mongodb.dir/build.make:1454: recipe for target 'CMakeFiles/mongodb.dir/libmongoc/src/mongoc/mongoc-collection.c.o' failed
```

It appears that ```mongoc-read-concern.h``` is included with <..> in ```mongoc-read-concern-private.h```, instead of with ".." like all the others:

```
derick@gargleblaster:~/dev/php/mongodb-mongo-hhvm-driver $ grep -r mongoc-read-concern.h
libmongoc/src/mongoc/mongoc-collection.h:#include "mongoc-read-concern.h"
libmongoc/src/mongoc/mongoc-client.h:#include "mongoc-read-concern.h"
libmongoc/src/mongoc/mongoc-read-concern-private.h:#include <mongoc-read-concern.h>
libmongoc/src/mongoc/mongoc-database-private.h:#include "mongoc-read-concern.h"
libmongoc/src/mongoc/mongoc-uri.h:#include "mongoc-read-concern.h"
libmongoc/src/mongoc/mongoc-database.h:#include "mongoc-read-concern.h"
libmongoc/src/mongoc/mongoc-read-concern.c:#include "mongoc-read-concern.h"
```

If I change the <..> to "..", compilation works, and all tests pass with libmongoc-1.3.0-beta0.



 Comments   
Comment by Githook User [ 20/Nov/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1019 include private header with quotes
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/7a1e32a08508611497575003db09f5e80b815121

Generated at Wed Feb 07 21:11:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.