[CDRIVER-1027] When running src/libmongoc/build/autotools/Versions.m4 out of scope, VERSION_* is cat'ed from the wrong directory Created: 02/Dec/15 Updated: 19/Oct/16 Resolved: 09/Dec/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build, libbson, libmongoc |
| Affects Version/s: | 1.3.0-rc0 |
| Fix Version/s: | 1.3.0 |
| Type: | Bug | Priority: | Blocker - P1 |
| Reporter: | Derick Rethans | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
The phongo build process sources "Versions.m4": ``` This results in: when running our "phpize" (akin to autogen.sh). It shows the errors once for libbson and once for libmongoc. the "cat" needs to be done on the files in the right directory. |
| Comments |
| Comment by Hannes Magnusson [ 09/Dec/15 ] | |||||||||||||||||||
|
Closing ticket – it was fixed in 1.3.0, accompanying a simplification in phongo | |||||||||||||||||||
| Comment by Githook User [ 07/Dec/15 ] | |||||||||||||||||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Revert "Unblock compile by copying VERSION_CURRENT and VERSION_RELEASED until This reverts commit aeb55cce75d1c18a38acd52847f29de9dfa22da4. | |||||||||||||||||||
| Comment by Hannes Magnusson [ 04/Dec/15 ] | |||||||||||||||||||
|
Heh. Now it gets passed the phpize stage but fails during ./configure. And of course it fails. $srcdir is the phongo srcdir, not mongoc. I've created a Pull Request for phongo to fix this though: https://github.com/mongodb/mongo-php-driver/pull/150 | |||||||||||||||||||
| Comment by Derick Rethans [ 04/Dec/15 ] | |||||||||||||||||||
|
Sorry, but this is not yet fixed. The location of the cat/cut errors has changed, but I still get:
and hence the compile errors later on return. By current branch for this is https://github.com/derickr/mongo-php-driver/tree/fix-libmongoc-version-issue | |||||||||||||||||||
| Comment by Githook User [ 04/Dec/15 ] | |||||||||||||||||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Also remove unused BSON_LT_LDFLAGS variable that was never | |||||||||||||||||||
| Comment by Githook User [ 04/Dec/15 ] | |||||||||||||||||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Also remove unused BSON_LT_LDFLAGS variable that was never substituted, | |||||||||||||||||||
| Comment by A. Jesse Jiryu Davis [ 02/Dec/15 ] | |||||||||||||||||||
|
bjori I think the right answer is to chdir to the proper directory before invoking these macros, but I'm uncertain. Another option is to provide some m4_define'd source-directory variable that Versions.m4 can use to find the libbson or libmongoc source directory. Notice, for example, that when libmongoc invokes libbson's ./autogen.sh, libbson does not encounter this problem, because it chdirs into src/libbson before invoking it. So it seems like expected behavior for our configure scripts to assume that the working directory is the repository root. | |||||||||||||||||||
| Comment by Githook User [ 02/Dec/15 ] | |||||||||||||||||||
|
Author: {u'username': u'derickr', u'name': u'Derick Rethans', u'email': u'github@derickrethans.nl'}Message: Unblock compile by copying VERSION_CURRENT and VERSION_RELEASED until |