[CDRIVER-1044] Enable -Werror for clang on Evergreen Created: 09/Dec/15  Updated: 30/Jan/17  Resolved: 17/Nov/16

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6.0

Type: Improvement Priority: Minor - P4
Reporter: Hannes Magnusson Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-669 Turn compiler warnings into errs on E... Closed
related to CDRIVER-1559 syscall deprecated in macOS Closed
Epic Link: C Driver in Evergreen

 Description   

Evergreen is now running with -Werror for GCC (on linux and solaris) successfully – but clang emits a handful of other warnings such as:

 [2015/12/09 05:48:58.793] src/bson/bson-reader.c:345:33: warning: cast from 'bson_reader_t *' to 'bson_reader_handle_t *' increases required alignment from 8 to 128 [-Wcast-align]
 [2015/12/09 05:48:58.793]    bson_reader_handle_t *real = (bson_reader_handle_t *)reader;

and

 [2015/12/09 05:49:20.057] tests/test-mongoc-collection.c:604:46: warning: format string is not a string literal [-Wformat-nonliteral]
 [2015/12/09 05:49:20.057]    gle_json_formatted = bson_strdupv_printf (gle_json, args);
 [2015/12/09 05:49:20.057]                                              ^~~~~~~~



 Comments   
Comment by Githook User [ 30/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch 'r1.5'

Comment by Githook User [ 30/Jan/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 Fix unknown-pragmas warning on clang3.4
Branch: master
https://github.com/mongodb/libbson/commit/709ececc1e23db7da74f69baaa743051ece6ce8c

Comment by Githook User [ 27/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 Fix unknown-pragmas warning on clang3.4
Branch: r1.5
https://github.com/mongodb/libbson/commit/709ececc1e23db7da74f69baaa743051ece6ce8c

Comment by Hannes Magnusson [ 17/Nov/16 ]

-Werror is now enabled on all buildvariants

Comment by Githook User [ 17/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 fix -Wint-conversion on macOS

incompatible pointer to integer conversion returning 'unsigned char *'
from a function with result type 'bool' (aka 'signed char')
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/d4c56c6ad702aab19515eeb1d295cc337d20c5df

Comment by Githook User [ 17/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/ea36df9f436fd9182cd35e820a6523f28b5a8a9c

Comment by Githook User [ 17/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044: incompatible pointer to integer conversion initializing 'bool' (aka 'signed char') with an expression of type 'void *'
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/fdb2fc62e5e96b9e95cc5ca749c6809b53a74be8

Comment by Githook User [ 17/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 Enable -Werror for clang on Evergreen
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/7e75d18fa946433f1c9af31287cd259651b398e8

Comment by Githook User [ 16/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior
Branch: master
https://github.com/mongodb/libbson/commit/d7df5dfd0d90989c424ad2cd06e2e3947f53788a

Comment by Githook User [ 16/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 Enable Werror on all buildvariants
Branch: master
https://github.com/mongodb/libbson/commit/2212081290a177b4c9a04d331c4358f6d5e168a8

Comment by Githook User [ 16/Nov/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1044 Fix unknown-pragmas warning on clang3.4
Branch: master
https://github.com/mongodb/libbson/commit/812d28c50b8714f64207314f58c7898b2d5a882f

Generated at Wed Feb 07 21:11:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.