[CDRIVER-1092] mongoc_cursor_new_from_command_reply Created: 09/Feb/16 Updated: 10/Aug/16 Resolved: 22/Feb/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.4.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Epic Link: | Public API for PHP drivers | ||||||||||||||||
| Description |
|
When a user executes a command using mongoc_client_command() that returns a "cursor document", such as executing "aggregate" and using the "cursor" option, we need a way for the user to create an actual mongoc_cursor_t from this document. |
| Comments |
| Comment by Githook User [ 06/Jul/16 ] | ||
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Leak found in unreleased code. | ||
| Comment by Githook User [ 26/Feb/16 ] | ||
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: | ||
| Comment by Githook User [ 23/Feb/16 ] | ||
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: | ||
| Comment by Hannes Magnusson [ 23/Feb/16 ] | ||
|
derick Its a new function that was added to replace https://github.com/mongodb/mongo-php-driver/blob/master/php_phongo.c#L654-L718 with
| ||
| Comment by Derick Rethans [ 23/Feb/16 ] | ||
|
Neither the HHVM or PHP drivers use the mongoc_cursor_new_from_command_document() function, so which API call does this actually replace? | ||
| Comment by Githook User [ 23/Feb/16 ] | ||
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: | ||
| Comment by A. Jesse Jiryu Davis [ 22/Feb/16 ] | ||
|
driver-php, check out how this is intended to be used for "aggregate", etc., cursors: https://github.com/mongodb/mongo-c-driver/blob/f3666/tests/test-mongoc-cursor.c#L636 To avoid extra copying of the reply, you allocate a bson_t with bson_new, store the result of mongoc_client_command_simple_with_hint there, then donate the bson_t to mongoc_cursor_new_from_command_reply, which now owns the reply and is responsible for freeing it. | ||
| Comment by Githook User [ 22/Feb/16 ] | ||
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |