[CDRIVER-1176] CMake: Add _Decimal128 type check Created: 24/Mar/16 Updated: 03/Oct/16 Resolved: 03/Oct/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.5.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
We need to convert the _Decimal128 check to CMake: https://github.com/mongodb/libbson/blob/master/build/autotools/CheckDecimal.m4 |
| Comments |
| Comment by Hannes Magnusson [ 03/Oct/16 ] |
|
The functions that used the platform native _Decimal128 type were removed. |
| Comment by Hannes Magnusson [ 25/Aug/16 ] |
|
Its not required no, it just add a nice little casting function from bson_decimal128_t to _Decimal128 so you don't have to do it yourself to use the native type. The _Decimal128 function is afaict currently only supported by gcc, not clang og VS |
| Comment by A. Jesse Jiryu Davis [ 25/Aug/16 ] |
|
Is this required for MongoDB 3.4 support? Or no, because our CMake build is mainly intended for Microsoft Visual C and _Decimal128 isn't supported there? |
| Comment by Githook User [ 25/Mar/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 24/Mar/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |