[CDRIVER-1191] Windows build error compiling libbson Created: 01/Apr/16 Updated: 26/Oct/20 Resolved: 04/Apr/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libbson |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.4.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
Spotted a few build errors (and warnings) while compiling 1.4.0 in VS2015 x86 for
|
| Comments |
| Comment by Scott Willis [ 26/Oct/20 ] | ||||
|
This issue (still) occurs when bson.h is #included before inttypes.h:
| ||||
| Comment by Hannes Magnusson [ 04/Apr/16 ] | ||||
|
Closing as works as designed. You probably did something weird while configuring libbson. | ||||
| Comment by Hannes Magnusson [ 01/Apr/16 ] | ||||
Line#62 is inside an
https://github.com/mongodb/libbson/blob/master/src/bson/bson-decimal128.h#L60 Can you check your code again? | ||||
| Comment by Jeremy Mikola [ 01/Apr/16 ] | ||||
|
PHP's aclocal.m4 and acinclude.m4 (presumably from phpize) both end up including the following snippet:
I see no other references to "inttypes.h" in the driver sources. Our config.w32 file is also disabling decimal 128 on Windows:
| ||||
| Comment by Hannes Magnusson [ 01/Apr/16 ] | ||||
|
Windows doesn't have _Decimal128. Where how/did you include inttypes.h? We either include inttypes or define the macros, not both. |