[CDRIVER-1316] Copy strings referred by mongoc_ssl_opts_t Created: 04/Jun/16 Updated: 07/Apr/17 Resolved: 08/Jun/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc, tls |
| Affects Version/s: | None |
| Fix Version/s: | 1.4.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Ian Boros |
| Resolution: | Done | Votes: | 0 |
| Labels: | intern2016 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
As reported by acm here: https://github.com/mongodb/mongo-cxx-driver/pull/490 ... it's surprising and dangerous that mongoc_client_set_ssl_opts and mongoc_client_pool_set_ssl_opts copy only the options struct, and not also the strings to which it refers. |
| Comments |
| Comment by Githook User [ 07/Apr/17 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge remote-tracking branch 'upstream/master'
|
| Comment by Githook User [ 07/Apr/17 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 09/Jun/16 ] |
|
Author: {u'username': u'puppyofkosh', u'name': u'puppyofkosh', u'email': u'puppyofkosh@gmail.com'}Message: |
| Comment by A. Jesse Jiryu Davis [ 08/Jun/16 ] |
|
No backport; I'm hoping not to do 1.3.6 at all, and if it is it'll be for incendiary bugs only. |
| Comment by Hannes Magnusson [ 08/Jun/16 ] |
|
That doesn't sound like a good idea at all. These are no longer consts, and I worry about the case where people use (or just read the docs for) the latest version of the driver, and then deploy on 1.3.5, and kaboom. Unless the docs are clearly updated with backwards and future compatible example, I don't think we should merge this to 1.3 |
| Comment by Andrew Morrow (Inactive) [ 08/Jun/16 ] |
|
Will this get backported to the 1.3 release? I don't need it to be as I've worked around the issue for now, but per the comment in https://github.com/mongodb/mongo-cxx-driver/pull/490 it sounds ilke it could be? |
| Comment by Githook User [ 08/Jun/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #329 from puppyofkosh/
|
| Comment by Githook User [ 08/Jun/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #329 from puppyofkosh/
|
| Comment by Githook User [ 08/Jun/16 ] |
|
Author: {u'name': u'ian boros', u'email': u'iboros@MacBook-Pro-57.local'}Message: |
| Comment by A. Jesse Jiryu Davis [ 06/Jun/16 ] |
|
Help users not segfault their process if they pass a temporary string as part of the driver's SSL configuration. |