[CDRIVER-1318] Enable test_ssl_reconnect_single / pooled for native TLS Created: 07/Jun/16  Updated: 10/Aug/16  Resolved: 10/Aug/16

Status: Closed
Project: C Driver
Component/s: tests, tls
Affects Version/s: None
Fix Version/s: 1.4.0

Type: Improvement Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CDRIVER-1148 /Async/ismaster_ssl fails on Darwin N... Closed

 Description   

ian.boros noticed these tests are guarded by #ifdef MONGOC_ENABLE_SSL_OPENSSL.

https://github.com/mongodb/mongo-c-driver/blob/master/tests/test-mongoc-client.c#L1678



 Comments   
Comment by Hannes Magnusson [ 10/Aug/16 ]

I'm a littlebit confused by the commit order in this ticket, but the tests in question are currently enabled on OpenSSL and Darwin.

I consider this ticket to be resolved

Comment by Hannes Magnusson [ 09/Aug/16 ]

these tests are using the mock server, where the mockserver is expected to provide the server tls implementation, using native tls.

This is not what a driver does, a driver provides the client implementations and thats what all of our implementations do.

The server side is very different. Unfortunately, Windows Secure Channel does not abstract all of the TLS details away, so the client and server side are very different. OpenSSL and Darwin Secure Transport do however provide a good abstraction and we can therefore trivially implement the server implementation too, and do. We do not do so on Windows as doing so is of no value to the driver, but requires pretty solid work.

Comment by Githook User [ 27/Jul/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1318 debug failures in timeout tests
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/848f68cb465c3e7c939e58a62c3fe873b9b74dc9

Comment by Githook User [ 27/Jul/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1318 re-disable async SSL tests on Darwin
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/3b72ea98e1d3eb0f7457951757a6aaeea49d367e

Comment by Githook User [ 27/Jul/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1318 enable reconnect tests for Darwin TLS
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/88d16a7f3aec738e41cab92f76be8bd805b13aab

Comment by A. Jesse Jiryu Davis [ 07/Jun/16 ]

Ah, thanks for the reminder. OK, let's leave them disabled for the moment.

Comment by Hannes Magnusson [ 07/Jun/16 ]

It was originally intentional, the mock server didn't quite play well with others, resulting in incorrect test failures.
If we can get it to work, it'd be awesome though

Generated at Wed Feb 07 21:12:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.