[CDRIVER-1332] Does bson_json_reader_new's allow_multiple have an effect? Created: 16/Jun/16 Updated: 05/Dec/22 Resolved: 29/Oct/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | json, libbson |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | intern2016 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Investigate what allow_multiple is supposed to mean and whether it has an effect. Test and document the reality. This about parsing a buffer like:
Read the YAJL documentation to see what it's supposed to mean. Could be that our error-handling code recovers when allow_multiple is false but we detect multiple docs, causing libbson to act as if allow_multiple is always true. |
| Comments |
| Comment by Githook User [ 29/Oct/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 29/Oct/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 29/Oct/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 29/Oct/16 ] |
|
Author: {u'name': u'Fiona Rowan', u'email': u'fiona.rowan@10gen.com'}Message: |
| Comment by Githook User [ 29/Oct/16 ] |
|
Author: {u'name': u'Fiona Rowan', u'email': u'fiona.rowan@10gen.com'}Message: |
| Comment by Hannes Magnusson [ 02/Sep/16 ] |
|
https://github.com/mongodb/libbson/pull/175 |
| Comment by A. Jesse Jiryu Davis [ 16/Jun/16 ] |
|
Thanks Hannes. If the flag is necessary, then there's a problem with test coverage: I can edit bson_json_reader_new to always set allow_multiple=false and all the tests pass. Same if I always set allow_multiple true. |
| Comment by Hannes Magnusson [ 16/Jun/16 ] |
|
This is to handle mongoexport -t json export files |