[CDRIVER-1347] Define per symbol visibility rather then using separate export symbol files Created: 29/Jun/16 Updated: 15/Feb/17 Resolved: 07/Oct/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
When we build with Autotools and gcc or clang, we specify which symbols to export with versions.ldscript, in both libbson and libmongoc. When we build with CMake and MS Visual Studio, we use libbson.def or libmongoc.def. Sometimes (in CLion on Mac or Linux, for example) we'll build with CMake and gcc or clang. Use versions.ldscript in that configuration, too. |
| Comments |
| Comment by Githook User [ 08/Oct/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #399 from jrassi/
|
| Comment by Githook User [ 08/Oct/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #399 from jrassi/
|
| Comment by Githook User [ 08/Oct/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 07/Oct/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 07/Oct/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Hannes Magnusson [ 05/Oct/16 ] |
|
libbson: |
| Comment by Hannes Magnusson [ 03/Oct/16 ] |
|
libbson: |
| Comment by A. Jesse Jiryu Davis [ 30/Sep/16 ] |
|
I like it, SGTM. |
| Comment by Hannes Magnusson [ 29/Sep/16 ] |
|
I think we should remove these files, the are consistent source of unnecessary problems and maintenance. Then we don't have to be juggling all these extra files, keeping them in sync, and making copies of them per build mutation (ssl, experimental, ..) |