[CDRIVER-1348] scan-build warnings (libbson) Created: 29/Jun/16  Updated: 10/Aug/16  Resolved: 18/Jul/16

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.4.0

Type: Bug Priority: Major - P3
Reporter: Hannes Magnusson Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-1406 scan-build warnings (mongoc) Closed

 Description   

scan-build warnings

 [2016/06/29 12:07:59.331] + scan-build-3.8 -o scan --status-bugs make test TEST_ARGS=--no-fork -F test-results.json
 [2016/06/29 12:07:59.403] scan-build: Using '/usr/lib/llvm-3.8/bin/clang' for static analysis
 [2016/06/29 12:07:59.427]   CC       tests/test_libbson-TestSuite.o
 [2016/06/29 12:08:02.095]   CC       tests/test_libbson-test-libbson.o
 [2016/06/29 12:08:02.272]   CC       tests/test_libbson-test-atomic.o
 [2016/06/29 12:08:02.498]   CC       tests/test_libbson-test-bson.o
 [2016/06/29 12:08:03.123]   CC       tests/test_libbson-test-endian.o
 [2016/06/29 12:08:03.357]   CC       tests/test_libbson-test-clock.o
 [2016/06/29 12:08:03.583]   CC       tests/test_libbson-test-decimal128.o
 [2016/06/29 12:08:03.891]   CC       tests/test_libbson-test-error.o
 [2016/06/29 12:08:04.118]   CC       tests/test_libbson-test-iso8601.o
 [2016/06/29 12:08:04.464]   CC       tests/test_libbson-test-iter.o
 [2016/06/29 12:08:04.809]   CC       tests/test_libbson-test-json.o
 [2016/06/29 12:08:05.703] tests/test-json.c:217:4: warning: Value stored to 'r' is never read
 [2016/06/29 12:08:05.703]    r = !!strstr(str, "...");
 [2016/06/29 12:08:05.703]    ^   ~~~~~~~~~~~~~~~~~~~~
 [2016/06/29 12:08:05.703] 1 warning generated.
 [2016/06/29 12:08:05.712]   CC       tests/test_libbson-test-oid.o
 [2016/06/29 12:08:05.990]   CC       tests/test_libbson-test-reader.o
 [2016/06/29 12:08:06.265]   CC       tests/test_libbson-test-string.o
 [2016/06/29 12:08:06.528]   CC       tests/test_libbson-test-utf8.o
 [2016/06/29 12:08:06.798]   CC       tests/test_libbson-test-value.o
 [2016/06/29 12:08:07.046]   CC       tests/test_libbson-test-version.o
 [2016/06/29 12:08:07.272]   CC       tests/test_libbson-test-writer.o
 [2016/06/29 12:08:07.522]   CC       tests/test_libbson-test-bcon-basic.o
 [2016/06/29 12:08:08.469]   CC       tests/test_libbson-test-bcon-extract.o
 [2016/06/29 12:08:08.884]   CC       tests/test_libbson-test-type.o
 [2016/06/29 12:08:11.867] tests/test-type.c:137:14: warning: Value stored to 'bson_input' during its initialization is never read
 [2016/06/29 12:08:11.868]       bson_t bson_input = BSON_INITIALIZER;
 [2016/06/29 12:08:11.868]              ^~~~~~~~~~   ~~~~~~~~~~~~~~~~
 [2016/06/29 12:08:11.868] tests/test-type.c:187:10: warning: Function call argument is an uninitialized value
 [2016/06/29 12:08:11.868]          valid (bson_str,
 [2016/06/29 12:08:11.868]          ^~~~~~~~~~~~~~~~
 [2016/06/29 12:08:11.868] 2 warnings generated.
 [2016/06/29 12:08:11.877]   CC       tests/test_libbson-json-test.o
 [2016/06/29 12:08:12.684]   CC       src/bson/libbson_la-bcon.lo
 [2016/06/29 12:08:15.786]   CC       src/bson/libbson_la-bson.lo
 [2016/06/29 12:08:18.470] src/bson/bson.c:1933:4: warning: Value stored to 'impl_i' is never read
 [2016/06/29 12:08:18.470]    impl_i = (bson_impl_inline_t *)b;
 [2016/06/29 12:08:18.470]    ^        ~~~~~~~~~~~~~~~~~~~~~~~
 [2016/06/29 12:08:18.470] 1 warning generated.
 [2016/06/29 12:08:18.484]   CC       src/bson/libbson_la-bson-atomic.lo
 [2016/06/29 12:08:19.310]   CC       src/bson/libbson_la-bson-clock.lo
 [2016/06/29 12:08:20.136]   CC       src/bson/libbson_la-bson-context.lo
 [2016/06/29 12:08:21.012]   CC       src/bson/libbson_la-bson-decimal128.lo
 [2016/06/29 12:08:22.452]   CC       src/bson/libbson_la-bson-error.lo
 [2016/06/29 12:08:23.290]   CC       src/bson/libbson_la-bson-iter.lo
 [2016/06/29 12:08:25.703]   CC       src/bson/libbson_la-bson-iso8601.lo
 [2016/06/29 12:08:26.593]   CC       src/bson/libbson_la-bson-json.lo
 [2016/06/29 12:08:29.260]   CC       src/bson/libbson_la-bson-keys.lo
 [2016/06/29 12:08:30.103]   CC       src/bson/libbson_la-bson-md5.lo
 [2016/06/29 12:08:31.628]   CC       src/bson/libbson_la-bson-memory.lo
 [2016/06/29 12:08:32.480]   CC       src/bson/libbson_la-bson-oid.lo
 [2016/06/29 12:08:34.036]   CC       src/bson/libbson_la-bson-reader.lo
 [2016/06/29 12:08:35.127]   CC       src/bson/libbson_la-bson-string.lo
 [2016/06/29 12:08:36.874]   CC       src/bson/libbson_la-bson-timegm.lo
 [2016/06/29 12:08:39.894]   CC       src/bson/libbson_la-bson-utf8.lo
 [2016/06/29 12:08:41.971]   CC       src/bson/libbson_la-bson-value.lo
 [2016/06/29 12:08:42.830]   CC       src/bson/libbson_la-bson-version-functions.lo
 [2016/06/29 12:08:43.671]   CC       src/bson/libbson_la-bson-writer.lo
 [2016/06/29 12:08:44.544]   CCLD     libbson.la
 [2016/06/29 12:08:44.748] ar: `u' modifier ignored since `D' is the default (see `U')
 [2016/06/29 12:08:44.801]   CC       src/yajl/libyajl_la-yajl_version.lo
 [2016/06/29 12:08:45.543]   CC       src/yajl/libyajl_la-yajl.lo
 [2016/06/29 12:08:46.348]   CC       src/yajl/libyajl_la-yajl_encode.lo
 [2016/06/29 12:08:49.577]   CC       src/yajl/libyajl_la-yajl_lex.lo
 [2016/06/29 12:08:53.886] src/yajl/yajl_lex.c:630:21: warning: Value stored to 'tok' is never read
 [2016/06/29 12:08:53.886]                     tok = yajl_tok_error;
 [2016/06/29 12:08:53.886]                     ^     ~~~~~~~~~~~~~~
 [2016/06/29 12:08:53.886] 1 warning generated.
 [2016/06/29 12:08:53.901]   CC       src/yajl/libyajl_la-yajl_parser.lo
 [2016/06/29 12:08:57.061]   CC       src/yajl/libyajl_la-yajl_buf.lo
 [2016/06/29 12:08:57.836]   CC       src/yajl/libyajl_la-yajl_tree.lo
 [2016/06/29 12:08:58.852] src/yajl/yajl_tree.c:267:23: warning: Access to field 'type' results in a dereference of a null pointer (loaded from field 'value')
 [2016/06/29 12:08:58.852]                       ctx->stack->value->type);
 [2016/06/29 12:08:58.852]                       ^~~~~~~~~~~~~~~~~~~~~~~
 [2016/06/29 12:08:58.852] src/yajl/yajl_tree.c:55:58: note: expanded from macro 'RETURN_ERROR'
 [2016/06/29 12:08:58.852]             snprintf ((ctx)->errbuf, (ctx)->errbuf_size, __VA_ARGS__);  \
 [2016/06/29 12:08:58.852]                                                          ^~~~~~~~~~~
 [2016/06/29 12:08:58.852] src/yajl/yajl_tree.c:435:5: warning: Value stored to 'status' is never read
 [2016/06/29 12:08:58.852]     status = yajl_parse(handle,
 [2016/06/29 12:08:58.852]     ^        ~~~~~~~~~~~~~~~~~~
 [2016/06/29 12:08:58.852] 2 warnings generated.

All of these look legit.

See https://evergreen.mongodb.com/task/libbson_releng_debug_compile_scan_build_0d22cadc6e97192fb3a7bd46163095e3ebd1ec58_16_06_29_18_50_02



 Comments   
Comment by Githook User [ 10/Aug/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1348 leak in example code
Branch: master
https://github.com/mongodb/libbson/commit/0d4fd7b9fadaa44eda1c8be3a869b709084609e5

Comment by Githook User [ 18/Jul/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1348 reenable scan-build
Branch: master
https://github.com/mongodb/libbson/commit/9bf599f636a6dd75ea1be6d74ed0b0f38adcb47d

Comment by Githook User [ 06/Jul/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1348: Disable scan-build builds until the bugs are fixed
Branch: master
https://github.com/mongodb/libbson/commit/757b89baf07c3a75a391770196604036b8f5df5d

Generated at Wed Feb 07 21:12:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.