[CDRIVER-1381] remove reply_local in mongoc_collection_find_and_modify_with_opts Created: 14/Jul/16 Updated: 10/Aug/16 Resolved: 22/Jul/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.4.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Fiona Rowan | Assignee: | Fiona Rowan |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Description |
|
In mongoc_collection_find_and_modify_with_opts, we keep and modify a local reply within the function, and then copy the contents to the reply passed in as an argument. This is inefficient, instead we will just modify the reply argument. |
| Comments |
| Comment by Githook User [ 22/Jul/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@10gen.com'}Message: Merge pull request #355 from fionaRowan/
|
| Comment by Githook User [ 22/Jul/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@10gen.com'}Message: Merge pull request #355 from fionaRowan/
|
| Comment by Githook User [ 22/Jul/16 ] |
|
Author: {u'name': u'Fiona Rowan', u'email': u'fiona.rowan@10gen.com'}Message: |