[CDRIVER-1404] Use S_ISDIR() instead of & S_IFDIR Created: 19/Jul/16  Updated: 07/May/18  Resolved: 27/Apr/17

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.7.0

Type: New Feature Priority: Major - P3
Reporter: Hannes Magnusson Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CDRIVER-1314 Support c89 Closed

 Description   

 [2016/07/18 21:17:47.655] + CFLAGS=-std=c89 -D_POSIX_C_SOURCE=200112L -m64 -march=x86-64 CC=clang ./autogen.sh --enable-html-docs=no --enable-man-pages=no --enable-yelp=no --enable-examples=no --enable-optimizations=no --enable-extra-align=no --enable-maintainer-flags --enable-debug --disable-silent-rules --disable-automatic-init-and-cleanup --with-libbson=bundled --enable-experimental-features

[2016/07/18 21:20:46.937] tests/json-test.c:465:66: error: use of undeclared identifier 'S_IFDIR'
 [2016/07/18 21:20:46.937]       if (0 == stat(child_path, &dir_stat) && dir_stat.st_mode & S_IFDIR) {
 [2016/07/18 21:20:46.937]                                                                  ^
 [2016/07/18 21:20:46.939] 1 error generated.

See https://github.com/mongodb/libbson/commit/98574198d844786d9f5d0d46d351b976842acc16

tests/ha-test.c:#define S_ISDIR(b) ((b)&_S_IFDIR)
tests/json-test.c:      if (0 == stat(child_path, &dir_stat) && dir_stat.st_mode & S_IFDIR) {

https://evergreen.mongodb.com/task_log_raw/mongo_c_driver_clang38_debug_compile_c89_f952591a1aaecd0a554521900ed183fae14db8e3_16_07_19_04_14_15/0?type=T



 Comments   
Comment by Githook User [ 27/Apr/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: Merge branch 'CDRIVER-1404-c89'

Comment by Githook User [ 27/Apr/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: Merge branch 'CDRIVER-1404-c89'

Comment by Githook User [ 27/Apr/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: Merge branch 'CDRIVER-1404-c89'

Comment by Githook User [ 27/Apr/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1404 Require at most -D_XOPEN_SOURCE=500 -D_POSIX_C_SOURCE=200112L
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/c04548d9e0a1df34a4d078aa7dd95f13357dcf15

Generated at Wed Feb 07 21:12:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.