[CDRIVER-1419] Setting handshake data should log error if unsuccessful Created: 26/Jul/16 Updated: 19/Oct/16 Resolved: 03/Aug/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Ian Boros | Assignee: | Ian Boros |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | mongodb-handshake | ||||||||
| Description |
|
If mongoc_client_set_appname or mongoc_client_pool_set_appname is called more than once, or with a string that's too long, they currently return false and do nothing else. The mongoc_client_set_apm_callbacks function, which has similar behavior (it can also only be called once), logs an error when it fails. The set_appname functions should follow the same convention. Be sure to update the docs as well. Also update the tests which test these cases to call capture_logs |
| Comments |
| Comment by Githook User [ 01/Aug/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #379 from puppyofkosh/
|
| Comment by Githook User [ 01/Aug/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #379 from puppyofkosh/
|
| Comment by Githook User [ 01/Aug/16 ] |
|
Author: {u'name': u'ian boros', u'email': u'ian.boros@10gen.com'}Message: |
| Comment by Ian Boros [ 01/Aug/16 ] |
|
PR: |