[CDRIVER-1423] "Stream is closed" sending large message on Windows with OpenSSL Created: 27/Jul/16 Updated: 09/Aug/16 Resolved: 09/Aug/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc, tests, tls |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.4.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Epic Link: | Native TLS and SCRAM-SHA-1 | ||||||||||||
| Description |
|
Seen here:
|
| Comments |
| Comment by A. Jesse Jiryu Davis [ 09/Aug/16 ] |
|
Reverted https://github.com/mongodb/mongo-c-driver/commit/8642ac1a6dd26cc265fbd25c35d7134a21deb0ae, this should fix the bug here. |
| Comment by Githook User [ 09/Aug/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Revert " This reverts commit d9b55e6ca8406544a3a13f3ee6dbf5409fec81d8. |
| Comment by A. Jesse Jiryu Davis [ 09/Aug/16 ] |
|
OK go for it. Let's reopen |
| Comment by Hannes Magnusson [ 08/Aug/16 ] |
|
I think all the ssl changes in https://github.com/mongodb/mongo-c-driver/commit/8642ac1a6dd26cc265fbd25c35d7134a21deb0ae should be reverted. Also considering the difficulty in confirming its correctness, and its only used by testing (while producing genuine errors in normal code), I think this ticket should be closed and |
| Comment by A. Jesse Jiryu Davis [ 01/Aug/16 ] |
|
I bet I introduced this bug here: In the same commit I introduced a bug in the OpenSSL integration, which I fixed here: https://github.com/mongodb/mongo-c-driver/commit/a9739598717eb82a214b7d3fbf922b666f7b345e Question is, what's the right way for a server-side Secure Channel stream to know the client has closed its side? |
| Comment by Githook User [ 27/Jul/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |