[CDRIVER-1452] Attempt to clean/normalize values collected in mongoc-metadata Created: 05/Aug/16 Updated: 19/Oct/16 Resolved: 02/Sep/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Ian Boros | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | mongodb-handshake | ||||||||
| Description |
|
In some parts of the metadata collection process, we do nothing to "sanitize" the strings we collect. For example, the values may have quotes around them. We also don't do much to make sure the values are whitespace trimmed. Hannes brought this up in a code review for the linux distro scanner, so I'm opening a ticket for it. I think we should either: a) Decide not to do this, and just put the responsibility on whoever is analyzing this data. b) Do this as a separate step in the mongoc-metadata code. If we go with this option we should define exactly what kind of sanitizing we want to do here. |
| Comments |
| Comment by Githook User [ 02/Sep/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: And use the distro name, not its ID. |
| Comment by Hannes Magnusson [ 29/Aug/16 ] |
|
These quotes for the distro name is getting a littlebit annoying. I think we should consider doing this sooner then later |
| Comment by Ian Boros [ 05/Aug/16 ] |
|
I'm putting my take on both options in this comment to separate my opinions from what the options (as I see them) are 1) 2) |