[CDRIVER-1458] Test failure in mongoc_socket check_closed Created: 08/Aug/16  Updated: 03/May/17  Resolved: 03/Apr/17

Status: Closed
Project: C Driver
Component/s: libmongoc, tests
Affects Version/s: None
Fix Version/s: 1.4.0, 1.7.0

Type: Bug Priority: Major - P3
Reporter: Ian Boros Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-1409 Test that topology scanner is still a... Closed
is related to CDRIVER-1423 "Stream is closed" sending large mess... Closed

 Description   

In an evergreen patch for an unrelated feature, I got a failure on OSX 64 nossl in the monogc-socket check_closed test. It seems like this test failed on the base patch as well. Here's the log for the base patch:

https://evergreen.mongodb.com/task/mongo_c_driver_os_x_1010_64_nossl_integration_test_3.0_replica_set_no_auth_cd4c2b4f636baca5719614fe9e82ff37a336090b_16_08_04_14_02_22

Here's the failure:

 [2016/08/05 14:16:21.892] Assertion failed: (closed == true), function socket_test_client, file tests/test-mongoc-socket.c, line 153.

It looks like none of the commits since then have been to address this bug, so maybe it still exists, but just isn't being "triggered."

Forgive me if this is a duplicate.



 Comments   
Comment by Githook User [ 03/Apr/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1458 reliable test_socket_check_closed

This had failed occasionally on Mac, because it assumes that as soon as
the server has closed its localhost connection, the client detects it.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/a2b338841637bf6ffa30ed72ac5115d18e383e38

Comment by Githook User [ 03/Apr/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Revert "CDRIVER-1458 disable /Socket/check_closed on Mac"

This reverts commit 5a108cbe60041e56aab878dd0cc8eeb251083fcf.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/87abf8e6a270ddd1b945b35706c8e8a6e7bcebb7

Comment by Githook User [ 29/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1458 disable /Socket/check_closed on Mac
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/5a108cbe60041e56aab878dd0cc8eeb251083fcf

Comment by Hannes Magnusson [ 09/Aug/16 ]

I can't repro this, and haven't actually seen this in the past several evergreen runs either.

I think it was related to the mockserver changes that were reverted at the same time as the closed_socket changes.

Comment by Hannes Magnusson [ 08/Aug/16 ]

This is a nossl build, so it wasn't caused by CDRIVER-1409 ....

Generated at Wed Feb 07 21:12:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.