[CDRIVER-1512] Lilbbson tests are built regardless if "--enable-tests=no" is set or not Created: 31/Aug/16 Updated: 19/Oct/16 Resolved: 31/Aug/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build, libbson |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.5.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Dmitry Ryabtsev | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
With Ideally the scope of "--enable-tests=no" should include libbson as well. |
| Comments |
| Comment by Githook User [ 31/Aug/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Hannes Magnusson [ 31/Aug/16 ] |
|
The --enable-tests option was never added to the autotools build system, only cmake, in libbson. Thats why its not being respected when configuring mongoc with --enable-tests=no. Related issue, --disable-examples is supported by mongoc, not libbson. |
| Comment by A. Jesse Jiryu Davis [ 31/Aug/16 ] |
|
Thanks for the report, we'll take a look. |