[CDRIVER-1512] Lilbbson tests are built regardless if "--enable-tests=no" is set or not Created: 31/Aug/16  Updated: 19/Oct/16  Resolved: 31/Aug/16

Status: Closed
Project: C Driver
Component/s: Build, libbson
Affects Version/s: 1.4.0
Fix Version/s: 1.5.0

Type: Improvement Priority: Minor - P4
Reporter: Dmitry Ryabtsev Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-1014 More config options in CMake build sy... Closed

 Description   

With CDRIVER-1014 implemented it is now possible to set "--enable-tests=no" option to avoid building tests for the driver. Still the libbson the driver depends on gets its tests built regardless if that option is used or not.

Ideally the scope of "--enable-tests=no" should include libbson as well.



 Comments   
Comment by Githook User [ 31/Aug/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-1512: backport -disable[examples|tests] from mongoc
Branch: master
https://github.com/mongodb/libbson/commit/f48a246c44c188a3508c7d0325edb33cfe7be7f9

Comment by Hannes Magnusson [ 31/Aug/16 ]

The --enable-tests option was never added to the autotools build system, only cmake, in libbson. Thats why its not being respected when configuring mongoc with --enable-tests=no.

Related issue, --disable-examples is supported by mongoc, not libbson.

Comment by A. Jesse Jiryu Davis [ 31/Aug/16 ]

Thanks for the report, we'll take a look.

Generated at Wed Feb 07 21:12:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.