[CDRIVER-1574] Remove --enable-hardening (which is a NOOP) Created: 03/Oct/16 Updated: 12/Jan/17 Resolved: 11/Oct/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
libbson and mongoc both have
Turns out however, the configured CFLAGS and LDFLAGS are never actually used by either libbson nor mongoc, and never have. |
| Comments |
| Comment by Githook User [ 12/Oct/16 ] | |||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||
| Comment by Githook User [ 11/Oct/16 ] | |||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||
| Comment by Hannes Magnusson [ 05/Oct/16 ] | |||
|
This broke platforms that actually support _FORTIFY_SOURCE
acm Raised a good point that.. maybe we shouldn't be doing this at all? If we choose to keep these flags, we need to actually check if they work. See https://github.com/mongodb/mongo/blob/master/SConstruct#L2384 | |||
| Comment by Githook User [ 05/Oct/16 ] | |||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||
| Comment by Githook User [ 05/Oct/16 ] | |||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||
| Comment by Hannes Magnusson [ 03/Oct/16 ] | |||
|
libsson: |