[CDRIVER-1577] Declare __cdecl as calling convention on Windows Created: 04/Oct/16 Updated: 13/Dec/16 Resolved: 12/Dec/16 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build, libbson, libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.6.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
This doesn't seem to impact other c apps on windows using mongoc, but when compiling c++ then the user may be tempted to change the calling convention: Unless we specifically declare which calling convention our API expects, things might get muddy. |
| Comments |
| Comment by Githook User [ 13/Dec/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 12/Dec/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 12/Dec/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by A. Jesse Jiryu Davis [ 28/Oct/16 ] |
|
I like the BSON_EXPORT idea best. I have no objection to running uncrustify on all headers.
|