[CDRIVER-1688] Test in Evergreen with hardening flags Created: 10/Oct/16 Updated: 20/Jul/17 Resolved: 20/Jul/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.8.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | mongoc-toolchain | ||||||||
| Description |
|
Compile libbson and libmongoc with hardening flags enabled and run the test suites in Evergreen to catch things like buffer overruns. See for example |
| Comments |
| Comment by Githook User [ 20/Jul/17 ] | |||||||||||||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||||||||||||
| Comment by A. Jesse Jiryu Davis [ 28/Oct/16 ] | |||||||||||||||
|
Sounds good to me. | |||||||||||||||
| Comment by Hannes Magnusson [ 27/Oct/16 ] | |||||||||||||||
|
Good question. Rather then adding this as a configure flags, we should probably just have a evergreen build stuffing the relevant flags into CFLAGS and run the tests. There is no need to have this as a configure flag, we don't provide binaries, and its up to the binary creators to decide on how to harden it. | |||||||||||||||
| Comment by A. Jesse Jiryu Davis [ 24/Oct/16 ] | |||||||||||||||
|
bjori is this a feature in our test suite, or a feature for all users who install the driver? What version do you want to release this in? | |||||||||||||||
| Comment by Hannes Magnusson [ 11/Oct/16 ] | |||||||||||||||
|
Couple of notes:
Requires enabling optimizations when built with _FIRTIFY_SOURCE |