[CDRIVER-1698] Regression test for "limit" and legacy writes Created: 13/Oct/16  Updated: 13/Oct/16  Resolved: 13/Oct/16

Status: Closed
Project: C Driver
Component/s: libmongoc, tests
Affects Version/s: 1.5.0
Fix Version/s: 1.5.0

Type: Improvement Priority: Minor - P4
Reporter: A. Jesse Jiryu Davis Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Add a regression test for:

https://github.com/mongodb/mongo-c-driver/commit/ad47d5c19b852ac9c4d4e82618d64552ac7600f7



 Comments   
Comment by A. Jesse Jiryu Davis [ 13/Oct/16 ]

Great!

Comment by Hannes Magnusson [ 13/Oct/16 ]

$ git revert ad47d5c19b852ac9c4d4e82618d64552ac7600f7
[master 8bac628] Revert "Check the correct iterator for the 'limit' field"
 1 file changed, 6 insertions(+), 8 deletions(-)
$ make test TEST_ARGS="-l /BulkOperation/remove_continue_on_error"
  "results": [
lt-test-libmongoc: tests/test-bulk.c:1429: test_remove_continue_on_error: Assertion `!r' failed.
    { "status": "FAIL", "test_file": "/BulkOperation/remove_continue_on_error", "seed": "887128045", "start": 1123690.302969325, "end": 1123690.490757874, "elapsed": 0.187788549  }
  ]
}
$ git revert 8bac628
[master 45c82fb] Revert "Revert "Check the correct iterator for the 'limit' field""
 1 file changed, 8 insertions(+), 6 deletions(-)
$ make test TEST_ARGS="-l /BulkOperation/remove_continue_on_error"
  "results": [
    { "status": "PASS", "test_file": "/BulkOperation/remove_continue_on_error", "seed": "2007149920", "start": 1123709.161583664, "end": 1123709.186449008, "elapsed": 0.024865344  }
  ]
}

$ mongod --version
db version v2.4.11
Thu Oct 13 11:09:45.521 git version: fa13d1ee8da0f112f588570b4070f73d7af2f7fd

Comment by Hannes Magnusson [ 13/Oct/16 ]

There is a test for it already. The prior build matrix didn't run against 2.4, so the build failure didn't get spotted until the entire matrix ran.

Generated at Wed Feb 07 21:13:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.