[CDRIVER-1896] Coverity analysis defect 76624: Side effect in assertion Created: 02/Nov/16  Updated: 21/Nov/16  Resolved: 21/Nov/16

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.5.0

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CDRIVER-1903 Bugs in _mongoc_gridfs_file_extend Closed

 Description   

Assertion contains an operation with a side effect

Defect 76624 (STATIC_C)
Checker ASSERT_SIDE_EFFECT (subcategory none)
File: /src/mongoc/mongoc-gridfs-file.c
Function _mongoc_gridfs_file_extend
/src/mongoc/mongoc-gridfs-file.c, line: 601
Assignment "file->length = target_length" has a side effect. This code will work differently in a non-debug build.

       BSON_ASSERT (file->length = target_length);



 Comments   
Comment by A. Jesse Jiryu Davis [ 21/Nov/16 ]

Fixed by CDRIVER-1903.

Comment by Githook User [ 03/Nov/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Revert "CDRIVER-1896 assignment in assert"

37b92878ae3df4465dbb7bf41b3e32a5d4d58319
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/3427c158404eb34b952208d5edb3d08909ba9aec

Comment by Githook User [ 02/Nov/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1896 assignment in assert
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/37b92878ae3df4465dbb7bf41b3e32a5d4d58319

Generated at Wed Feb 07 21:13:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.