[CDRIVER-1982] MinGW: wrong ifdef check for strerror_r Created: 06/Jan/17  Updated: 30/Jan/17  Resolved: 06/Jan/17

Status: Closed
Project: C Driver
Component/s: libbson, mingw
Affects Version/s: None
Fix Version/s: 1.5.2

Type: Bug Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Wrong:

 
#if defined(__GNUC__) && defined(_GNU_SOURCE)
   ret = strerror_r (err_code, buf, buflen);
#elif defined(_WIN32)
   if (strerror_s (buf, buflen, err_code) != 0) {
      ret = buf;
   }
#else /* XSI strerror_r */
   if (strerror_r (err_code, buf, buflen) == 0) {
      ret = buf;
   }
#endif

Should be:

 
#if defined(_WIN32)
   if (strerror_s (buf, buflen, err_code) != 0) {
      ret = buf;
   }
#elif defined(__GNUC__) && defined(_GNU_SOURCE)
   ret = strerror_r (err_code, buf, buflen);
#else /* XSI strerror_r */
   if (strerror_r (err_code, buf, buflen) == 0) {
      ret = buf;
   }
#endif



 Comments   
Comment by Githook User [ 30/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch 'r1.5'

Comment by Githook User [ 30/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1982 fix ifdef for strerror_s with mingw
Branch: master
https://github.com/mongodb/libbson/commit/edf7ea92ab1ddd82263e70925bb4240ebaa0912d

Comment by Githook User [ 10/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1982 fix ifdef for strerror_s with mingw
Branch: r1.5
https://github.com/mongodb/libbson/commit/edf7ea92ab1ddd82263e70925bb4240ebaa0912d

Comment by Githook User [ 06/Jan/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-1982 fix ifdef for strerror_s with mingw
Branch: master
https://github.com/mongodb/libbson/commit/307b436937c064c5d3e1a33729c5a582e1ccaae4

Comment by A. Jesse Jiryu Davis [ 06/Jan/17 ]

Reported by david.golden related to the Strawberry Perl distribution, which compiles Perl and extensions with MinGW on Windows.

Generated at Wed Feb 07 21:13:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.