[CDRIVER-2012] Move MONGOC_ENABLE_SASL_SSPI guard up in mongoc-cluster-sspi.c Created: 01/Feb/17  Updated: 01/Feb/17  Resolved: 01/Feb/17

Status: Closed
Project: C Driver
Component/s: libmongoc
Affects Version/s: None
Fix Version/s: 1.6.0

Type: Bug Priority: Major - P3
Reporter: Jeremy Mikola Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by PHPC-892 Upgrade libbson and libmongoc to 1.6.0 Closed
Related
is related to CDRIVER-299 Native GSSAPI on windows Closed

 Description   

Per this GitHub comment, the #ifdef MONGOC_ENABLE_SASL_SSPI guard should be moved above the private header includes, as is done for other C files with conditional code (e.g. mongoc-cluster-sasl.c). As-is, it's possible the trigger the following build error when including this C file when SSPI was not found (i.e. MONGOC_ENABLE_SASL_SSPI is undefined):

src/mongoc/mongoc-sspi-private.h:32:21: fatal error: Windows.h: No such file or directory



 Comments   
Comment by Githook User [ 01/Feb/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-2012 Move MONGOC_ENABLE_SASL_SSPI guard up in mongoc-cluster-sspi.c
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/af574ec268388ffc05587e45173f6754a8895cc1

Generated at Wed Feb 07 21:13:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.