[CDRIVER-2030] Deprecated options should be ignored if replacement exists Created: 04/Feb/17  Updated: 03/May/17  Resolved: 21/Feb/17

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.7.0

Type: Task Priority: Major - P3
Reporter: Hannes Magnusson Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: C Driver Connection String Spec

 Description   

diff --git a/tests/json/connection_uri/valid-warnings.json b/tests/json/connection_uri/valid-warnings.json
index 507c6d3..385f024 100644
--- a/tests/json/connection_uri/valid-warnings.json
+++ b/tests/json/connection_uri/valid-warnings.json
@@ -14,23 +14,6 @@
       ],
       "auth": null,
       "options": null
-    },
-    {
-      "description": "Deprecated (or unknown) options are ignored if replacement exists",
-      "uri": "mongodb://example.com/?wtimeout=5&wtimeoutMS=10",
-      "valid": true,
-      "warning": true,
-      "hosts": [
-        {
-          "type": "hostname",
-          "host": "example.com",
-          "port": null
-        }
-      ],
-      "auth": null,
-      "options": {
-        "wtimeoutms": 10
-      }
     }
   ]
 }

This does actually seem like a bug in the spec tests as we don't actually support wtimeout at all..



 Comments   
Comment by Githook User [ 21/Feb/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-2030 Don't include the exact option name in the check

Not all the tests use the same option name to generate the warning
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/ab929d352afc47e949b36f151be0505417b81457

Comment by Githook User [ 21/Feb/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: Revert "CDRIVER-2030 - Deprecated options should be ignored if replacement exists"

This reverts commit 3cfded64be28858f1fe9f8c7756c4afd0bb649ce.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/a51e387f551d563c62a8c8cec02523a8d5772354

Comment by Githook User [ 06/Feb/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: Merge branch 'CDRIVER-784-connection-uri-spec'

Comment by Githook User [ 06/Feb/17 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-2030 - Deprecated options should be ignored if replacement exists
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/3cfded64be28858f1fe9f8c7756c4afd0bb649ce

Generated at Wed Feb 07 21:13:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.