[CDRIVER-2060] localThresholdMS is not validated as a non-negative value Created: 16/Feb/17  Updated: 02/Mar/17  Resolved: 02/Mar/17

Status: Closed
Project: C Driver
Component/s: libmongoc, uri
Affects Version/s: 1.5.4, 1.6.0
Fix Version/s: 1.5.5, 1.6.1

Type: Bug Priority: Minor - P4
Reporter: Jeremy Mikola Assignee: Jeremy Mikola
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-2056 mongoc_uri_get_option_as_int32() does... Closed
related to CDRIVER-2058 heartbeatFrequencyMS is not validated... Closed
is related to CDRIVER-2059 Topology component uses signed and un... Backlog

 Description   

This is related to CDRIVER-2059, where a parsed "localThresholdMS" option is treated as int32_t, int64_t, and size_t in various places. This is a separate ticket to propose the addition of validation logic for the URI option, independent of how it is passed around within the topology component.



 Comments   
Comment by A. Jesse Jiryu Davis [ 02/Mar/17 ]

r1.6:

CDRIVER-2060: Validate that localThresholdMS URI option is non-negative https://github.com/mongodb/mongo-c-driver/commit/e353c3e5836be21416d1bc63128cc523d1a60c6c

CDRIVER-2060 localThreshold code cleanups https://github.com/mongodb/mongo-c-driver/commit/24d880edf042d4236c0ed41427afdccd3ce6815d

Comment by Githook User [ 02/Mar/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-2060 localThreshold code cleanups
Branch: r1.5
https://github.com/mongodb/mongo-c-driver/commit/052809bd89e69d7cd650d493246e2db8b46e93c3

Comment by Githook User [ 02/Mar/17 ]

Author:

{u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}

Message: CDRIVER-2060: Validate that localThresholdMS URI option is non-negative
Branch: r1.5
https://github.com/mongodb/mongo-c-driver/commit/d1a6795f1ffd3b4c1722eaeb57c3a13c8f15acc1

Comment by Githook User [ 28/Feb/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-2060 localThreshold code cleanups
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/e9e3a6c9f0f2b982a015612d4682b5caabc38627

Comment by Githook User [ 28/Feb/17 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #424 from jmikola/1.5-cdriver-2056

CDRIVER-2056, CDRIVER-2060: Improve localThresholdMS URI option parsing
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/faa52777ba79797ebab1a231c20a413cd2e310cc

Comment by Githook User [ 28/Feb/17 ]

Author:

{u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}

Message: CDRIVER-2060: Validate that localThresholdMS URI option is non-negative
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/e51f87cddbd02bae14f3b71a38b7d213e70ca638

Comment by Jeremy Mikola [ 16/Feb/17 ]

https://github.com/mongodb/mongo-c-driver/pull/424

Generated at Wed Feb 07 21:14:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.