[CDRIVER-209] mongo_cursor_get_more should not call mongo_cursor_destroy Created: 19/Apr/13 Updated: 09/Aug/13 Resolved: 09/Aug/13 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 0.7.1 |
| Fix Version/s: | 0.8.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Brahneborg | Assignee: | Gary Murakami |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The function mongo_cursor_get_more() should not call mongo_cursor_destroy(), Diff, which includes the incorrect bson_free mentioned in ticket diff --git a/src/mongo.c b/src/mongo.c
|
| Comments |
| Comment by auto [ 08/Aug/13 ] |
|
Author: {u'username': u'gjmurakami-10gen', u'name': u'Gary J. Murakami', u'email': u'gary.murakami@10gen.com'}Message: mongo_cursor_get_more should not call mongo_cursor_destroy
|
| Comment by Daniel Brahneborg [ 23/Apr/13 ] |
|
As far as I can see, both calls must be removed. |
| Comment by ahmed talha khan [ 23/Apr/13 ] |
|
Encountered the same issue with tailable cursor with mongo restarting. So which one is the better approach? Removing the extraneous bson_free() call which causes a double free on reply? or removing the mongo_cursor_destroy() call? |