[CDRIVER-2131] mongoc_client_pool_push should mention the configurable uri options Created: 19/Apr/17 Updated: 28/Oct/23 Resolved: 29/Jan/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | docs, libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
The mongoc_client_pool_push docs should say that the client is destroyed if it exceeds the uri configured min_pool_size. the pop function should also say when a new client is created and how that is configured. the connection string docs for those values may also need improvements to restate how it works as it isn't identical with other implementations as pointed out by david.golden
|
| Comments |
| Comment by Githook User [ 29/Jan/18 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by David Golden [ 19/Apr/17 ] |
|
Also, the discontinuity of "0" and "1" in minPoolSize is strange. There is no way to configure the pool to destroy all clients if all are returned. If I understand this correctly, then minPoolSize of "0" is effectively the same as setting minPoolSize = maxPoolSize (i.e. create up to maxPoolSize clients and then never destroy any). |
| Comment by David Golden [ 19/Apr/17 ] |
|
I think the behavior of mongoc_client_pool_push might be incorrect, or rather that the C driver's interpretation of minPoolSize design intent is incorrect. Maybe this ticket should be re-titled to be a fix for minPoolSize. I think the current behavior is equivalent to this:
Does libmongoc create minPoolSize idle clients when the pool is created? If not, isn't the "min" on "minPoolSize" misleading? |