[CDRIVER-2144] Support compression of legacy write opcodes Created: 26/Apr/17 Updated: 27/Oct/23 Resolved: 15/Jun/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.8.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | CDRIVER OP_COMPRESSED |
| Comments |
| Comment by Hannes Magnusson [ 15/Jun/17 ] |
|
The spec has been amended to remove this requirement: https://github.com/mongodb/specifications/commit/7ec78a857d6c53e85d7c08fd78687121363e52d6 |
| Comment by Hannes Magnusson [ 27/Apr/17 ] |
|
The latest revision of the spec demands all operations to be compressed when compression had been negotiated. This was required by driver leads. Compression can be negotiated in MongoDB 3.4, so when we do w=0 write, we must compress legacy writes too. |
| Comment by A. Jesse Jiryu Davis [ 27/Apr/17 ] |
|
Remind me: why would we ever need to compress OP_INSERT, etc.? If the server is new enough to support OP_COMPRESSED, then we'll send writes using OP_MSG, even for unacknowledged writes - do I understand correctly? |