[CDRIVER-2169] Return value for bson_decimal128_from_string is undocumented Created: 24/May/17 Updated: 28/Oct/23 Resolved: 25/May/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libbson |
| Affects Version/s: | None |
| Fix Version/s: | 1.7.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Samuel Rossi (Inactive) | Assignee: | Hannes Magnusson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
The documentation for bson_decimal128_from_string doesn't say anything about the return value. I assume that it returns whether or not it was able to parse a bson_decimal128_t from the string (and populates the out argument if true), but this should probably be explicitly stated. |
| Comments |
| Comment by Hannes Magnusson [ 25/May/17 ] |
|
reviewed and approved now |
| Comment by Hannes Magnusson [ 24/May/17 ] |
|
whops. that commit was not supposed to be pushed, I merged the wrong branch it looks like. The CR is still open for review |
| Comment by Githook User [ 24/May/17 ] |
|
Author: {'email': 'bjori@php.net', 'name': 'Hannes Magnusson', 'username': 'bjori'}Message: |
| Comment by Hannes Magnusson [ 24/May/17 ] |
|
Note: the out argument is always populated. |