[CDRIVER-2191] Evergreen patch builds download the wrong release archive Created: 17/Jun/17  Updated: 27/Oct/23  Resolved: 19/Jun/17

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: Backlog - C Driver Team
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

For example, see this patch build:

https://evergreen.mongodb.com/version/59459f2f2fbabe3f7e00129e

Although the patch includes a change to mongoc-cyrus.c, the version of that file included in both the tarballs uploaded by the "make release archive" task is from master, not from the patch build.

Let's figure out why "make release archive" uploads two tarballs, and why neither includes the patched files.



 Comments   
Comment by A. Jesse Jiryu Davis [ 19/Jun/17 ]

Thanks Hannes, I had been confused, all the uploaded tarballs do include the patched files. (I think I was confused about mongoc-cluster-cyrus.c versus mongoc-cyrus.c.)

It seems odd that we have both "upload working dir" and "upload build", which both upload all files in the working directory. But perhaps it makes sense in the context of the entire Evergreen project.

Comment by Hannes Magnusson [ 19/Jun/17 ]

I downloaded the working directory from that failed task, and it has the change to mongoc-cyrus.c added in that patch.
It seems to have correctly downloaded the patched tar file too:

[2017/06/17 14:57:37.467] + curl --retry 5 http://s3.amazonaws.com/mciuploads/mongo-c-driver/master/mongo-c-driver-1.6.0-334-g9f9934d-patch-59459f2f2fbabe3f7e00129e.tar.gz --output mongoc.tar.gz --silent --max-time 120

where g9f9934d is the closest git commit and 59459f2f2fbabe3f7e00129e is the evergreen version (same as the url).
It also seems to have extracted this file correctly:

[2017/06/17 15:00:06.144] C:\data\mci\fe2fa2966d944cba3afeda755e39c330\mongoc\build-dir>C:\cygwin\bin\tar xf ..\..\mongoc.tar.gz -C . --strip-components=1 

Generated at Wed Feb 07 21:14:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.