[CDRIVER-2207] Introduce generic mongoc_client_command_with_opts() function Created: 10/Jul/17 Updated: 28/Oct/23 Resolved: 04/Nov/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.9.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Epic Link: | Cdriver MongoDB 3.6 Support | ||||||||||||||||||||||||||||||||
| Description |
|
As discussed with jesse, this would be implemented in the style of mongoc_client_read_write_command_with_opts() (and friends) but only support a server hint and collation options by default. There would be no logic for injecting client defaults for read and write concern, which would make this suitable for basic commands such as ping. It would also serve as the model for a generic command runner for driver sessions, since the APIs for mongoc_client_command() and mongoc_client_command_simple() should be retired. |
| Comments |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: Revert " This reverts commit f98224425e0ae7f40896f42978e5c89b07ef8ab8. |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: Revert " This reverts commit e784642c4f5470bd50f585fbf9668b33787b76cf. |
| Comment by Githook User [ 04/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 04/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by A. Jesse Jiryu Davis [ 31/Oct/17 ] |
|
Still have to deprecate mongoc_database_command. |
| Comment by Githook User [ 28/Oct/17 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by Githook User [ 28/Oct/17 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: Generic command function that takes arbitrary opts. Required for using |
| Comment by A. Jesse Jiryu Davis [ 04/Oct/17 ] |
|
When we do this, let's finally mark mongoc_client_command deprecated. Consider deprecating mongoc_client_command_simple too. |