[CDRIVER-2236] Don't require SASL and SSL in order to make distribution tarball Created: 08/Aug/17  Updated: 28/Oct/23  Resolved: 11/Aug/17

Status: Closed
Project: C Driver
Component/s: Build, libmongoc
Affects Version/s: None
Fix Version/s: 1.8.0

Type: Task Priority: Minor - P4
Reporter: A. Jesse Jiryu Davis Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Currently in src/mongoc/Makefile.am there are lots of checks like this:

if ENABLE_SSL
INST_H_FILES += src/mongoc/mongoc-rand.h
endif

That means that if the build machine doesn't have the required dependencies (on my Ubuntu machine, libssl-dev and libsasl2-dev), then those headers aren't included in the distribution tarball by "make dist".

It seems like it should be irrelevant whether the build machine has these dependencies. We always want to include these files in the tarball.



 Comments   
Comment by Ramon Fernandez Marina [ 12/Sep/17 ]

Author:

{'username': u'bjori', 'name': u'Hannes Magnusson', 'email': u'bjori@php.net'}

Message:Merge branch 'CDRIVER-2236-make-dist'

Comment by Ramon Fernandez Marina [ 12/Sep/17 ]

Author:

{'username': u'bjori', 'name': u'Hannes Magnusson', 'email': u'bjori@php.net'}

Message:CDRIVER-2236 Don't require SASL and SSL in order to make distribution tarball
Branch:master
https://github.com/mongodb/mongo-c-driver/commit/0a14b9da664b52f6e54b59c55c59171cf98ec30a

Comment by Hannes Magnusson [ 11/Aug/17 ]

https://github.com/mongodb/mongo-c-driver/commit/993f24585f9c33dcd065e441da06466d6e78a7e1

Comment by Hannes Magnusson [ 08/Aug/17 ]

yeah, this check should only be for the .c files, not the .h files. we want all -private.h as NOINST_H_FILES and all other .h as INST_H_FILES

Generated at Wed Feb 07 21:14:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.