[CDRIVER-2266] Superfluous `off` in mongoc_buffer_t Created: 07/Sep/17  Updated: 28/Oct/23  Resolved: 26/Jan/18

Status: Closed
Project: C Driver
Component/s: libmongoc
Affects Version/s: None
Fix Version/s: 1.10.0

Type: Improvement Priority: Major - P3
Reporter: Hannes Magnusson Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CDRIVER-3672 Remove superfluous memmove calls in m... Closed

 Description   

The mongoc_buffer_t contains an unused field, off, which no longer (if ever) does anything.
It is still referenced to though in some of the math calculations, making it a bit confusing since the value is always 0.

We should remove this field



 Comments   
Comment by Kevin Albertson [ 14/May/20 ]

The original commit: https://github.com/mongodb/mongo-c-driver/commit/a569454477aa1726407264a078c041ea64fa38dd
(Must not have been picked up by the git hooks).

Comment by Githook User [ 11/Oct/18 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}

Message: delete unnecessary memmove

During CDRIVER-2266 this memmove call, which had once served a purpose,
became a logical no-op.
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/26137b5c0883bd0705833c0ec9212694d9c88650

Generated at Wed Feb 07 21:14:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.