[CDRIVER-2366] Use OP_MSG for unacknowledged writes Created: 12/Nov/17 Updated: 28/Oct/23 Resolved: 25/Jan/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | 1.9.0 |
| Fix Version/s: | 1.10.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Pavithra Vetriselvan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Reading the code, it appears to me that _mongoc_write_command_execute uses OP_MSG iff the wire version is at least 6, even for unacknowledged write concerns. It calls mongoc_cluster_run_opmsg which always sets flags to 0. It doesn't set the moreToCome flag, and it always expects a server response. Update this: set moreToCome to 1, use an implicit session even if the user passed an explicit one (ignore explicit sessions with unack'ed writes), and don't expect a server response. |
| Comments |
| Comment by Githook User [ 11/Jan/18 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by Githook User [ 11/Jan/18 ] |
|
Author: {'email': 'pavi@MacBook-Pro-77.local', 'name': 'Pavithra Vetriselvan'}Message: |