[CDRIVER-2369] Don't bundle Snappy Created: 13/Nov/17 Updated: 28/Oct/23 Resolved: 16/Nov/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Build, libmongoc |
| Affects Version/s: | 1.8.0 |
| Fix Version/s: | 1.8.2 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
We've attempted to bundle libsnappy into the C Driver, to provide Snappy compression on systems where libsnappy has not already been installed. We do this very oddly, however: instead of compiling Snappy's code into the C Driver, we actually compile libsnappy as a separate installable (or several installables) and install it into the system library path alongside libmongoc. This has caused many problems for people who want to link against libmongoc: they must now add -lsnappy to the link line to link to libmongoc, and they need a C++ linker. If we compiled Snappy's source into libmongoc, then libmongoc would depend on the C++ standard library, and it would still require a C++ linker. This is not worth the mess for the sake of better compression without depending on a system library. Users who want Snappy will need to install it before building the driver. We'll unbundle Snappy in 1.8.2. |
| Comments |
| Comment by Githook User [ 17/Jan/18 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: |
| Comment by Githook User [ 16/Jan/18 ] |
|
Author: {'email': 'jmikola@gmail.com', 'name': 'Jeremy Mikola', 'username': 'jmikola'}Message: |
| Comment by Githook User [ 12/Dec/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com', 'username': 'ajdavis'}Message: |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 16/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 16/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |