[CDRIVER-2370] Command monitoring and OP_MSG document sequences Created: 14/Nov/17 Updated: 28/Oct/23 Resolved: 04/Dec/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | 1.9.0 |
| Fix Version/s: | 1.9.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
MongoDB 2.6 write commands have arrays called "documents", "updates", and "deletes" which contain the array of operations. These are absent from the command body with OP_MSG, and they're added as document sequences instead.
In libmongoc 1.9, when we send an OP_MSG with a document sequence to the server, simulate a command body that includes the document sequence as a BSON array in order to preserve the same API as OP_QUERY write commands. |
| Comments |
| Comment by Githook User [ 05/Dec/17 ] |
|
Author: {'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}Message: |
| Comment by Githook User [ 05/Dec/17 ] |
|
Author: {'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}Message: New design: take the document sequence from an OP_MSG insert, update, or |
| Comment by Githook User [ 05/Dec/17 ] |
|
Author: {'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}Message: Revert " This reverts commit 51c7384 |
| Comment by Githook User [ 05/Dec/17 ] |
|
Author: {'username': 'ajdavis', 'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis'}Message: Revert " This reverts commit 34165fb |
| Comment by A. Jesse Jiryu Davis [ 23/Nov/17 ] |
|
derick the outcome of the spec debate is that we'll maintain the pre-3.6 behavior. Documents that are actually kept separate in OP_MSG document sequences for "insert", "update", and "delete" commands will be included in the command document published with mongoc_apm_command_started_t. This should be implemented before 1.9.0, and PHPC won't need to make any changes to its Command Monitoring tests. |
| Comment by A. Jesse Jiryu Davis [ 20/Nov/17 ] |
|
Reopening while a spec debate is resolved. And rename the simulated reply fields to cursor.firstBatch and cursor.nextBatch. |
| Comment by Githook User [ 20/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 20/Nov/17 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: Update Command Monitoring (also known as APM) to expose the document In MongoDB 3.8 there will be document sequences in the OP_MSG reply to |