[CDRIVER-2374] Non C99 GNU extension Created: 14/Nov/17 Updated: 28/Oct/23 Resolved: 19/Nov/17 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.8.1 |
| Fix Version/s: | 1.9.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeroen Ooms [X] | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
We need pure C99 for the R bindings (no GNU extensions).
To fix simply cast the pointer to a typed pointer (e.g. int*) before incrementing it. |
| Comments |
| Comment by Githook User [ 04/Jan/18 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by Githook User [ 19/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: Decided not to test clang on Ubuntu with -std=c99 -pedantic after all. | ||||
| Comment by Githook User [ 19/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by Githook User [ 19/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by Githook User [ 19/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by Jeroen Ooms [X] [ 18/Nov/17 ] | ||||
|
Hmm I'm not seeing that error on clang. The gcc manual page says: Allowable bit-field types other than _Bool, signed int, and unsigned int (C99 6.7.2.1). | ||||
| Comment by A. Jesse Jiryu Davis [ 18/Nov/17 ] | ||||
|
Fixed, thanks Jeroen. We regularly test compiling the driver with GCC and "-std=c99", but not with "-std=c99 -pedantic". I tried it just now and see a new error that I don't know how to fix:
This is GCC 4.8 on Ubuntu. I guess you don't see that error Jeroen? | ||||
| Comment by Githook User [ 18/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by Githook User [ 18/Nov/17 ] | ||||
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: | ||||
| Comment by A. Jesse Jiryu Davis [ 15/Nov/17 ] | ||||
|
Thanks, want to open a PR? |