[CDRIVER-2402] Allow mongoc to be added as subproject Created: 22/Nov/17 Updated: 28/Oct/23 Resolved: 07/Sep/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | cmake |
| Affects Version/s: | None |
| Fix Version/s: | 1.10.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | iulian | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | master | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Description |
|
With CMake we have the ability to add an existing project as subproject, and to be compiled during the superproject build. |
| Comments |
| Comment by A. Jesse Jiryu Davis [ 07/Sep/18 ] |
|
We've merged the libbson and libmongoc repositories into one repository, and if libbson is not install on your system then building libmongoc now builds libbson by default. |
| Comment by Githook User [ 26/Jan/18 ] |
|
Author: {'name': 'Iulian Rotaru', 'username': 'tzulea', 'email': 'iulian.rotaru@gmail.com'}Message: If the current source directory is not the source directory (i.e mongoc |
| Comment by A. Jesse Jiryu Davis [ 24/Nov/17 ] |
|
Great, thanks for the explanation. We'll do this in a future release, perhaps 1.10. This is nearly the same feature as When we merge this, I want to be very careful about the ENABLE_STATIC logic, it looks ok to me but requires thought. |
| Comment by iulian [ 23/Nov/17 ] |
|
I have uploaded a test project. Cheers. |
| Comment by iulian [ 22/Nov/17 ] |
|
from clonning github branch of mongoc i saw that libbson is a submodule. so doing git submodule update --init --recursive will get us the libbson source code. There is a similar request for cxx : https://jira.mongodb.org/browse/CXX-1173 Regarding Disabling message function: question: why not use directly message function from cmake ? mesage(STATUS ..) mesage(FATAL_ERROR ..) : https://cmake.org/cmake/help/v3.0/command/message.html Hopefully i was clear regarding testing. |
| Comment by A. Jesse Jiryu Davis [ 22/Nov/17 ] |
|
Can you explain a little more how this works? How do I test this? Do I git clone libbson and mongo-c-driver as two sibling directories and compile them both from a new CMakeLists that refers to each of them? Also, why disable messages from libbson configuration if libbson is a submodule? I think that output is still informative. |
| Comment by iulian [ 22/Nov/17 ] |
|
bson pull request: |