[CDRIVER-2435] _mongoc_write_opquery() contains logic for handling session replies Created: 19/Dec/17 Updated: 28/Oct/23 Resolved: 28/Jan/18 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | 1.9.0 |
| Fix Version/s: | 1.10.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
_mongoc_write_opquery() is only used if the wire version is < 6, where sessions would not be supported, yet it calls _mongoc_client_session_handle_reply(). This looks like dead code. |
| Comments |
| Comment by Githook User [ 28/Jan/18 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by A. Jesse Jiryu Davis [ 04/Jan/18 ] |
|
Also remove the "session" parameter to the function - no sessions are ever used with OP_QUERY commands. |