[CDRIVER-245] Drivers should only talk to servers with overlapping wire versions Created: 16/Oct/13 Updated: 05/Dec/13 Resolved: 14/Nov/13 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.90.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Barrie Segal | Assignee: | Christian Hergert |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Comments |
| Comment by Christian Hergert [ 14/Nov/13 ] |
|
Code and tests are in master. |
| Comment by Christian Hergert [ 14/Nov/13 ] |
|
I've added a test to verify we get the expected error thrown when connecting to incompatible wire versions. https://github.com/chergert/libmongoc/commit/9d32ca9fe0777629ea9e655cdf992045be1ffd23 |
| Comment by Christian Hergert [ 13/Nov/13 ] |
|
That is a good idea. I started on a pthread based mock server in tests a while ago. I'll see if I can bring that up today so we can ensure failure. |
| Comment by Mira Carey [ 13/Nov/13 ] |
|
The functionality looks fine, but ideally we'd get some kind of shim in to test this. Maybe it's worth starting in on a mock mongod? |
| Comment by Christian Hergert [ 13/Nov/13 ] |
|
https://github.com/chergert/libmongoc/commit/6e6f2e2198bad2bfe4e8bdb339a64d5ede138ac4 |